Flatpress Github release - Test with PHP 8.2 Alpha 1

[laborix]

Some PHP errors after running the current Github Flatpress (June 2022) on a Web server with PHP 8.2 Alpha 1 installed:

PHP Deprecated: Creation of dynamic property plugin_indexer::$enabledlist is deprecated in ...
PHP Deprecated: Creation of dynamic property Plugin_PrettyURLs::$mode is deprecated in ...
PHP Deprecated: Creation of dynamic property BPlusTree_Node::$storage is deprecated in ...
PHP Deprecated: Creation of dynamic property SBPlusWalker::$startnode is deprecated in ...
PHP Deprecated: Creation of dynamic property FPDB_Query::$comments is deprecated in ...
PHP Deprecated: Creation of dynamic property StringParser_BBCode::$_output is deprecated in ...
PHP Deprecated: Creation of dynamic property Smarty_Compiler::$_dvar_math_regexp is deprecated in ...

More than 573 lines are listed in the phperror.log file

It seems that the current Github Flatpress version produce a known PHP RFC: Deprecate dynamic properties situation.
see Details on: https://wiki.php.net/rfc/deprecate_dynamic_properties

regards

[Arvid]

Mëh - we're still working on the 8.1 changes, and already 8.2 brings new fun

Okay, then let's do it (but after the 8.1 stuff is done!) - I opened issue 115.

Thanks for reporting - you can be relied on as always

[laborix]

... Thanks for reporting - you can be relied on as always ...

Always a pleasure

[bttr]

Mëh - we're still working on the 8.1 changes, and already 8.2 brings new fun

Yes. This fast "evolution" of programming languages breaking old code is not funny.

[laborix]

98% of this PHP Warnings can be solved by adding the appropriate Variable definition in the right places within the classes.

See example: /fp-inludes/core/core.fpdb.class.php
PHP Deprecated: Creation of dynamic property FPDB_Query::$comments is deprecated in ...

Code: Select all

...
class FPDB_Query { 
...
public $comments = NULL;
...

Nothing more.

[Arvid]

Yep, but it needs to be done, though

[Arvid]

I think I got them all with 107f6d9 - can you confirm?

[Arvid]

Must have missed a few in October
Fixed some more with 104b960.

[laborix]

There's new work to do

The current test environment with "error_reporting = E_ALL":
Nginx 1.24, PHP 8.2.15 and FlatPress Github 1142

The FlatPress Github 1142 version with PrettyURLs produces the following PHP errors in the quick test under PHP 8.2.15:

Code: Select all

PHP Deprecated:  Creation of dynamic property Plugin_PrettyURLs::$baseurl is deprecated in .../fpgit1142/fp-plugins/prettyurls/plugin.prettyurls.php on line 253
PHP Deprecated:  Creation of dynamic property Plugin_PrettyURLs::$mode is deprecated in .../fpgit1142/fp-plugins/prettyurls/plugin.prettyurls.php on line 254
PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in .../fpgit1142/fp-plugins/prettyurls/plugin.prettyurls.php on line 302
PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in .../fpgit1142/fp-plugins/prettyurls/plugin.prettyurls.php on line 306
PHP Deprecated:  strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in .../fpgit1142/fp-plugins/prettyurls/plugin.prettyurls.php on line 309
PHP Deprecated:  strlen(): Passing null to parameter #1 ($string) of type string is deprecated in .../fpgit1142/fp-plugins/prettyurls/plugin.prettyurls.php on line 309

Otherwise, the quick test of the FlatPress Github 1142 version under PHP 8.2.15 with a quick test of the comment options (admin/external user) does not look bad

[fraenkiman]

Hello Laborix,

thank you for testing and reporting. I have created an issue for this.

With best regards
Frank